kutsan / zsh-system-clipboard

System clipboard key bindings for Zsh Line Editor with vi mode. It is similar to what `set clipboard=unnamed` does for vim.
GNU General Public License v3.0
149 stars 16 forks source link

Fix install instruction #44

Closed brorbw closed 2 years ago

kutsan commented 2 years ago

Thanks @brorbw! Is ZSH_CUSTOM coming from oh-my-zsh framework? I think we should also change the source line (line 34) in addition to this. There is also native ZDOTDIR variable we should consider using.

doronbehar commented 2 years ago

Thanks @brorbw! Is ZSH_CUSTOM coming from oh-my-zsh framework? I think we should also change the source line (line 34) in addition to this. There is also native ZDOTDIR variable we should consider using.

I agree.

brorbw commented 2 years ago

@kutsan I think it’s from oh-my-zsh. Let me investigate. I agree about L34

kutsan commented 2 years ago

Looks good to me, thanks! I think we can say that people who tweaked the ZDOTDIR variable should be able to figure out where to install. So we don't need to handle that case. Thanks again!

brorbw commented 2 years ago

I agree. I looked into ZDOTDIR which is unset on a default oh-my-zsh install so I think is a very small group of people. You are very welcome!