Closed ghost closed 6 years ago
We need to at least change hash to whence then. hash doesn't appear to respect path on freebsd.
@gregf Are you sure? Unlike whence
, hash
doesn't give you an output about the path. It just gives you an exit code, 0
or 1
. I don't have a FreeBSD machine right now. Can you try editing the plugin file locally try using with hash
?
You are right, not sure why I thought that the other day when I did this. Do you want me to resubmit or do you want to just add the |freebsd* yourself?
Please don't open another pull request. If you can --force
push it like I said above, I can merge it this PR.
I mean commit again with --amend
and push with --force
.
Thanks again! Much appericated it.
Thank you but I don't think we should repeat the existing code for nothing. We could have done that like this:
If you can
--force
update the commit, I can merge it.