search

kuwisdelu / Cardinal

Mass spectrometry imaging toolbox
http://www.cardinalmsi.org
36 stars 14 forks source link

Default `tolerance` in `pixels()` is too large #37

Closed kuwisdelu closed 4 months ago

kuwisdelu commented 4 months ago

The default tolerance for pixels() is set to the estimated spatial resolution (minimum difference between pixel positions), which means pixels will also match their neighbors. Set it to half the estimated resolution.

kuwisdelu commented 4 months ago

Note: This does not effect BioC release 3.19 due a different implementation of matter::estres() in the release.

kuwisdelu commented 4 months ago

Addressed by https://github.com/kuwisdelu/Cardinal/commit/2d33a25a8158069e3e43899fc26d6960b436ca59