search

kuzeko / graph-databases-testsuite

Docker Images, installation scripts, and testing & benchmarking suite for Graph Databases
https://graphbenchmark.com
MIT License
36 stars 9 forks source link

Rename runtime/errors runtime/results #1

Closed kuzeko closed 6 years ago

kuzeko commented 6 years ago

People get confused by the files runtime/errors runtime/results as they do not have extensions, so we should rename them to runtime/errors.log runtime/results.log

Moreover, we sometimes use runtime/errors just for debug info, so we should check when this happens and instead use a runtime/debug.log file.

MartinBrugnara commented 6 years ago

Results is a csv then it will become results.csv.
Loaders always log loading time into results.csv not matter if they are executed in debug or mode or not (debug mode does not influence performance of custom loaders).

kuzeko commented 6 years ago

Agreed. Not sure if current implementation only prints csv style info there

MartinBrugnara commented 6 years ago

The grep line in tp{2,3}/execute.sh takes care of it =)

kuzeko commented 6 years ago

smart!

MartinBrugnara commented 6 years ago

@kuzeko, wrt all the "this goes to debug.log". Once in query mode we use errors.log for debug see al the System.err.print(.

kuzeko commented 6 years ago

I see, we can live with that then. I'll close the issue. We'll reopen if something seems out of place.