kuzeko / graph-databases-testsuite

Docker Images, installation scripts, and testing & benchmarking suite for Graph Databases
https://graphbenchmark.com
MIT License
36 stars 9 forks source link

Check if dataset exists in the specialized init scripts #2

Open kuzeko opened 6 years ago

kuzeko commented 6 years ago

Before the check for the version https://github.com/kuzeko/graph-databases-testsuite/blob/d0d93a89fdb2edb1136be87c67fe5193fba93200/images/init/neo4j-tp3-init.sh#L20-L27

we should check if any dataset with that name exists, something like, but for all versions https://github.com/kuzeko/graph-databases-testsuite/blob/d0d93a89fdb2edb1136be87c67fe5193fba93200/runtime/tp3/execute.sh#L23-L26

MartinBrugnara commented 6 years ago

To avoid overriding you mean?

kuzeko commented 6 years ago

No, is just for having a better error management. The error that is thrown right now is ambiguous, it is not clear if the dataset exists but in the wrong version, or if doesn't exists at all.

MartinBrugnara commented 6 years ago

Ah, sure. I agree.