search

kuznia-rdzeni / coreblocks

RISC-V out-of-order core for education and research purposes
https://kuznia-rdzeni.github.io/coreblocks/
BSD 3-Clause "New" or "Revised" License
36 stars 14 forks source link

Fix benchmark workflow #670

Closed xThaid closed 5 months ago

xThaid commented 5 months ago
  1. I changed red triangles 🔺🔻 to black ones ▲▼, because a) there are no green arrows in unicode, b) for some metrics lower value means better, but for some don't and I don't want to implement this logic as well.
  2. Fixes the bug when a PR was opened with benchmark label and the workflow was triggered twice.
  3. Fixed problem with write permissions. It only happened on PRs with a branch from a fork. Github by default never gives access tokens with write permissions to workflows running in the context of changes coming from the fork (that's unsafe). The solution was to create a new workflow that runs in the context of the master branch (trusted context) and trigger that workflow after the benchmark workflow is completed.

I tested the changes on my own fork.

Fixes #669

tilk commented 5 months ago
  1. I changed red triangles 🔺🔻 to black ones ▲▼, because a) there are no green arrows in unicode, b) for some metrics lower value means better, but for some don't and I don't want to implement this logic as well.

Fair enough, I think that this should have an issue, though - colored triangles might be possible by using LaTeX or embedded SVGs.

piotro888 commented 5 months ago

Maybe the arrow can be changed to white up and red down for now?