search

kuznia-rdzeni / coreblocks

RISC-V out-of-order core for education and research purposes
https://kuznia-rdzeni.github.io/coreblocks/
BSD 3-Clause "New" or "Revised" License
33 stars 13 forks source link

Fix double logger adding #693

Closed lekcyjna123 closed 1 month ago

lekcyjna123 commented 2 months ago

I moved adding of our custom logger to "session" fixture, so there shouldn't be any more problems with duplicated logs. I tested it with command:

pytest -k FetchUnit_0 -s --log-level=debug

Resolves #675 Based on #573

tilk commented 2 months ago

You can't separate this change from #573?

lekcyjna123 commented 2 months ago

I can, but both edits the same part of code, so there will be conflict between them if this review will be based on master.

tilk commented 2 months ago

This seems to be a straightforward change, and it also fixes a very annoying bug, so it could be merged very quickly. Meanwhile #573 has now around 500 lines of code and a number of features besides the main one (the CAM), so I expect that PR to be reviewed after some time.

lekcyjna123 commented 2 months ago

Ok, I will prepare a separate change, but this would be probably in Sunday.

lekcyjna123 commented 1 month ago

I have created a version which is based on master. Please see #694