kuzudb / explorer

Browser-based user interface for Kùzu graph database
https://hub.docker.com/r/kuzudb/explorer
MIT License
29 stars 5 forks source link

Hardcoded kuzu path for development #28

Closed Riolku closed 11 months ago

Riolku commented 11 months ago

In development, we use the following code to find kuzu:

  const kuzuPath = path.join(
    __dirname,
    "..",
    "..",
    "..",
    "kuzu",
    "tools",
    "nodejs_api",
    "build/"
  );
  kuzu = require(kuzuPath);

../../../kuzu/tools/nodejs_api/build

I suppose this is a convenience path for the author. One option to fix this would be to add an environment variable.

mewim commented 11 months ago

The development server is intended to work with the kuzu submodule under the root directory of the UI project. The generate-grammar and build-kuzu scripts in package.json are configured accordingly, so I think it is best to just checkout the submodule instead of providing flexibility here.

Riolku commented 11 months ago

I think I misunderstood where this path resolves to.