kuzudb / explorer

Browser-based user interface for Kùzu graph database
https://hub.docker.com/r/kuzudb/explorer
MIT License
34 stars 5 forks source link

fix codestyle basedon eslint #62

Closed Ashleyhx closed 11 months ago

mewim commented 11 months ago

Good job overall.

A few TODOs:

  1. Update README.md and add instructions regarding how to run linter and auto-fix into the development section.
  2. Double check the behavior of add-and-commit@v9. If nothing to commit, will it quit silently/cause CI to fail/crate an empty commit?
  3. On push to master branch, it should still run linter, but not auto-fix anything, this is consistent with the branch protection rule of no direct commit to master. Also, pushing to master may cause deployment to be re-triggered, which can potentially cause a race condition of deploying two releases concurrently.
  4. For the deployment workflow, make it depending on lint, so that the deployment to Dockerhub is only done when the linter passes.