Update README.md and add instructions regarding how to run linter and auto-fix into the development section.
Double check the behavior of add-and-commit@v9. If nothing to commit, will it quit silently/cause CI to fail/crate an empty commit?
On push to master branch, it should still run linter, but not auto-fix anything, this is consistent with the branch protection rule of no direct commit to master. Also, pushing to master may cause deployment to be re-triggered, which can potentially cause a race condition of deploying two releases concurrently.
For the deployment workflow, make it depending on lint, so that the deployment to Dockerhub is only done when the linter passes.
Good job overall.
A few TODOs:
README.md
and add instructions regarding how to run linter and auto-fix into the development section.add-and-commit@v9
. If nothing to commit, will it quit silently/cause CI to fail/crate an empty commit?master
branch, it should still run linter, but not auto-fix anything, this is consistent with the branch protection rule of no direct commit tomaster
. Also, pushing tomaster
may cause deployment to be re-triggered, which can potentially cause a race condition of deploying two releases concurrently.