Closed wenhoujx closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +92.08
:tada:
Comparison is base (
3e04497
) 0.00% compared to head (7408e23
) 92.08%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@ray6080 thanks for the pointers, i updated the code and tests. Let me know if i need to further update. THanks !
@ray6080 thanks for the pointers, i updated the code and tests. Let me know if i need to further update. THanks !
Thanks! Looks good to me. Before merging the PR, can you manually squash your commits into one? We follow the principle of one commit for one pr, so it looks better on master commit history.
We always do git rebase
to squash commits in your branch into a single one first, then sync local master with the latest remote (if necessary), and git rebase master
, finally force push the branch.
great, i like squashing to one commit too.
done merging into one commit.
have you considered turn on github merge & squash
option? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests
have you considered turn on github
merge & squash
option? https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-squashing-for-pull-requests
Good point, I think this will squash all commits of a pr into a single one, while we currently keep two for each. Though it doesn't matter, it's just that we didn't follow this way from day 1 😅
y, that doesn't matter, thanks for reviewing my PR.
fixes #1482
add int16 and int32 support according to: https://arrow.apache.org/docs/format/CDataInterface.html#data-type-description-format-strings
please let me know where is the best place to add a test for this. (I haven't touched C++ for years ... )
I have read and agree to the terms under CLA.md.