Closed benjaminwinger closed 10 months ago
Attention: 9 lines
in your changes are missing coverage. Please review.
Comparison is base (
6175606
) 91.52% compared to head (3e71420
) 90.57%.:exclamation: Current head 3e71420 differs from pull request most recent head 748465a. Consider uploading reports for the commit 748465a to get more accurate results
Files | Patch % | Lines |
---|---|---|
src/storage/store/column.cpp | 66.66% | 8 Missing :warning: |
src/storage/compression/compression.cpp | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was going to benchmark this, as it adds an extra step to the decompression, but I'm not sure it's actually being used. Are internalIDs actually stored anywhere other than in rels?
You're right. Currently it's not materialized in node tables.
@benjaminwinger , can we hold this PR a bit longer after the rel node group one #2246 ?
Yes, I was thinking it would make sense to wait until that's merged so it can be tested.
I think this can be closed now. @benjaminwinger
Yes, let's close in favour of #2579
I was going to benchmark this, as it adds an extra step to the decompression, but I'm not sure it's actually being used. Are internalIDs actually stored anywhere other than in rels?