Open benjaminwinger opened 4 months ago
Attention: Patch coverage is 66.66667%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 93.37%. Comparing base (
b491af2
) to head (6f52967
). Report is 81 commits behind head on master.:exclamation: Current head 6f52967 differs from pull request most recent head 5f9f4e7
Please upload reports for the commit 5f9f4e7 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
src/common/types/value/nested.cpp | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I've re-enabled some rust tests which had been disabled due to them not being fully supported as they now appear to be working. Passing unions as parameters still doesn't seem to be supported, however I noticed a change to how union tags are handled which hadn't been propagated to the rust API, so I moved the tag type details into the
LogicalType::UNION
function to handle them all in one place.