search

kuzzleio / kuzzle-admin-console

A SPA to administrate your Kuzzle: index and collection management, document creation, realtime subscription and permissions management
http://console.kuzzle.io
Apache License 2.0
61 stars 25 forks source link

fix initial filter displayed value issue #922

Closed berthieresteban closed 2 years ago

berthieresteban commented 3 years ago

fix #908

berthieresteban commented 3 years ago

I agree with you It was a quickfix to resolve the bug, I just didn't have more time to spend Also, I'm going to look a little bit more because with the history system it is possible to load a filter so the problem may not come from the Filters component but from the way it is used in this view

berthieresteban commented 3 years ago

@xbill82 I found the problem We were using a custom component AutoFocusInput with a two-way binding using v-model but we were not using the value property setted by the v-model instead we were re creating a value data so the v-model only worked from child to parent

xbill82 commented 3 years ago

Thanks @berthieresteban ! This is why I'm always afraid of two-way bindings...

xbill82 commented 3 years ago

Yo, this implementation is valid, but... May I ask you to try to just use (in the b-input) 

:value="value"
@input="$emit('input', $event)

So that the component becomes stateless?

Just to try if it works...

berthieresteban commented 3 years ago

Could we discuss again about the auto-focus feature in this component ? I really don't like the implementation... I don't even know there was that feature in the admin console, is it still used actually ? The autofocus prop from bootstrap-vue could be enough ?

Aschen commented 3 years ago

@xbill82 @Njuelle updates on this?

xbill82 commented 3 years ago

@Aschen the auto-focus input is a feature you added, so we wanted to discuss it with you. Can we call a quick meeting or do you prefer to discuss it here asynchronously?

Aschen commented 3 years ago

We can remove it :+1:

netlify[bot] commented 2 years ago

✔️ Deploy Preview for heuristic-goodall-67c4b1 ready!

🔨 Explore the source changes: 71654c2590804c83df69aa151a2ab40b3b925f05

🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-goodall-67c4b1/deploys/61767800b07aaa00085445f0

😎 Browse the preview: https://deploy-preview-922--heuristic-goodall-67c4b1.netlify.app

xbill82 commented 2 years ago

I added some comments in code to explain what I've done, since the PR was opened by Esteban.