Add compatibility to kuzzle RC9+

kuzzleio / kuzzle-plugin-cluster

Kuzzle cluster mode

Apache License 2.0

7 stars 2 forks source link

Add compatibility to kuzzle RC9+ #29

Closed stafyniaksacha closed 7 years ago

stafyniaksacha commented 7 years ago

Bug fixes

Broker connection between master <-> slaves is now working
Merges data from master into slaves is now working
Slave broker disconnection leak

Boyscooting

Uses ES6 class syntax
Add debug mode though kuzzle:cluster* tag

stafyniaksacha commented 7 years ago

Sorry to not have rebased my commit history :-1:

benoitvidis commented 7 years ago

putting the pr in wip to address the issues in comment + fix unit tests

ballinette commented 7 years ago

looks good, but is there any strong reason to switch from Prototype to Class paradigm ?

xbill82 commented 7 years ago

@ballinette the idiomatic heritage?

benoitvidis commented 7 years ago

@balinette this is not a real paradigm switch. ES2015 class syntax does (almost) the same as util.inherits & co. We just took the opportunity of this fix to use this more up-to-date & cleaner syntax.

ballinette commented 7 years ago

@benoitvidis I know it's not really a paradigm and more a syntaxic sugar.

My wonder is just that I did not notice if we had a consensus about that in the team, and I don't want to have an heterogeneous code with both class and Prototype syntaxes.

So at least, if everybody agrees, we should act that all new features should privilege class syntax, and that we move gradually the actual code from Prototype to class.

That said, it's a more general thinkings and is not directly related to this PR in particular, so I'm not blocking it for that