Closed benoitvidis closed 5 years ago
Merging #76 into 3-dev will increase coverage by
1.03%
. The diff coverage is86.11%
.
@@ Coverage Diff @@
## 3-dev #76 +/- ##
==========================================
+ Coverage 57.03% 58.07% +1.03%
==========================================
Files 4 4
Lines 533 539 +6
==========================================
+ Hits 304 313 +9
+ Misses 229 226 -3
Impacted Files | Coverage Δ | |
---|---|---|
lib/redis/manager.js | 33.33% <0%> (+2.18%) |
:arrow_up: |
lib/index.js | 50.36% <100%> (+1.29%) |
:arrow_up: |
lib/node.js | 77.38% <90.9%> (-0.17%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5cd1285...69044b8. Read the comment docs.
What does this PR do ?
This PR is the fixed version of https://github.com/kuzzleio/kuzzle-plugin-cluster/pull/74 which, in its original version, would remove the strategies loaded at Kuzzle start -_-;....
How should this be manually tested?
dummy
strategy does not exist by trying to log indummy
strategy is known on all nodesdummy
strategy has been deleted from all nodesAdditionally, you can run kuzzle functional tests:
./node_modules/.bin/cucumber-js --profile websocketNoRedis
Boyscout
dependencies upgrade.