kuzzleio / kuzzle-plugin-cluster

Kuzzle cluster mode
Apache License 2.0
7 stars 2 forks source link

Kzl 998 strategies in redis #76

Closed benoitvidis closed 5 years ago

benoitvidis commented 5 years ago

What does this PR do ?

This PR is the fixed version of https://github.com/kuzzleio/kuzzle-plugin-cluster/pull/74 which, in its original version, would remove the strategies loaded at Kuzzle start -_-;....

How should this be manually tested?

  1. check the local strategy is still working, for instance by using the admin console
  2. test "on-the-flight" strategies addon and removal:

Additionally, you can run kuzzle functional tests:

  1. switch Kuzzle version to https://github.com/kuzzleio/kuzzle/pull/1284
  2. from kuzzle directory, run ./node_modules/.bin/cucumber-js --profile websocketNoRedis

Boyscout

dependencies upgrade.

codecov-io commented 5 years ago

Codecov Report

Merging #76 into 3-dev will increase coverage by 1.03%. The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##            3-dev      #76      +/-   ##
==========================================
+ Coverage   57.03%   58.07%   +1.03%     
==========================================
  Files           4        4              
  Lines         533      539       +6     
==========================================
+ Hits          304      313       +9     
+ Misses        229      226       -3
Impacted Files Coverage Δ
lib/redis/manager.js 33.33% <0%> (+2.18%) :arrow_up:
lib/index.js 50.36% <100%> (+1.29%) :arrow_up:
lib/node.js 77.38% <90.9%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cd1285...69044b8. Read the comment docs.