kuzzleio / kuzzle

Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -
https://kuzzle.io
Apache License 2.0
1.44k stars 124 forks source link

Bad plugin config causes entire management to be stuck #431

Closed xbill82 closed 8 years ago

xbill82 commented 8 years ago

I have broken the config of my passport-oauth plugin, since my config does not have a clientID field, which causes an error when the plugin is refreshed. The problem is that I see this error causes all the plugin management operations to crash.

Steps to reproduce

Failed to execute CLI action: OAuth2Strategy requires a clientID option
xbill82 commented 8 years ago

Reproducing this issue after #403 and now:

kuzzle_1 | KuzzleServer-0 error: 2016-10-26T10:24:47+00:00 [LOG:ERROR] OAuth2Strategy requires a clientID option
kuzzle_1 | KuzzleServer-0 TypeError: OAuth2Strategy requires a clientID option
kuzzle_1 | KuzzleServer-0     at Strategy.OAuth2Strategy (/var/app/node_modules/passport-google-oauth2/node_modules/passport-oauth2/lib/strategy.js:82:34)
kuzzle_1 | KuzzleServer-0     at new Strategy (/var/app/node_modules/passport-google-oauth2/lib/oauth2.js:48:18)
kuzzle_1 | KuzzleServer-0     at /var/app/node_modules/kuzzle-plugin-auth-passport-oauth/lib/passport/strategy.js:34:18
kuzzle_1 | KuzzleServer-0     at Array.forEach (native)
kuzzle_1 | KuzzleServer-0     at module.exports.config.init (/var/app/node_modules/kuzzle-plugin-auth-passport-oauth/lib/passport/strategy.js:18:41)
kuzzle_1 | KuzzleServer-0     at module.exports.init.isDummy [as init] (/var/app/node_modules/kuzzle-plugin-auth-passport-oauth/lib/index.js:33:16)
kuzzle_1 | KuzzleServer-0     at /var/app/lib/api/core/plugins/pluginsManager.js:84:23
kuzzle_1 | KuzzleServer-0     at replenish (/var/app/node_modules/async/dist/async.js:884:21)
kuzzle_1 | KuzzleServer-0     at iterateeCallback (/var/app/node_modules/async/dist/async.js:869:21)
kuzzle_1 | KuzzleServer-0     at /var/app/node_modules/async/dist/async.js:847:20
kuzzle_1 | KuzzleServer-0     at /var/app/lib/api/core/plugins/pluginsManager.js:106:9
kuzzle_1 | KuzzleServer-0     at replenish (/var/app/node_modules/async/dist/async.js:884:21)
kuzzle_1 | KuzzleServer-0     at iterateeCallback (/var/app/node_modules/async/dist/async.js:869:21)
kuzzle_1 | KuzzleServer-0     at /var/app/node_modules/async/dist/async.js:847:20
kuzzle_1 | KuzzleServer-0     at /var/app/lib/api/core/plugins/pluginsManager.js:106:9
kuzzle_1 | KuzzleServer-0     at replenish (/var/app/node_modules/async/dist/async.js:884:21)