Repository methods: `options` parameter is not homogenous - Githubissues

kuzzleio / kuzzle

Open-source Back-end, self-hostable & ready to use - Real-time, storage, advanced search - Web, Apps, Mobile, IoT -

https://kuzzle.io

Apache License 2.0

1.44k stars 124 forks source link

Repository methods: `options` parameter is not homogenous #985

Closed ballinette closed 6 years ago

ballinette commented 7 years ago

While reading PR #982 , I noticed that:

in method Repository.delete( https://github.com/kuzzleio/kuzzle/blob/master/lib/api/core/models/repositories/repository.js#L197 ), options has following format (cache options and database options are merged):
```
{
a_cache_option: 'foobar',
refresh: request.input.args.refresh
}
```
while in method UserRepository.persist (https://github.com/kuzzleio/kuzzle/blob/master/lib/api/core/models/repositories/userRepository.js#L68 ), it has following format (cache options and database options are separated):
```
{
cache: {
a_cache_option: 'foobar'
},
database: {
refresh: request.input.args.refresh
}
}
```

we should harmonize that...

ballinette commented 6 years ago

Issue moved to kuzzleio/kuzzle-backlog #185 via ZenHub