kuzzleio / sdk-go

Golang SDK using the WebSocket protocol to communicate with Kuzzle API including offline resiliency

http://docs.kuzzle.io/sdk/go/2

Apache License 2.0

8 stars 5 forks source link

Change options.offline_mode type #180

Closed Aschen closed 6 years ago

Aschen commented 6 years ago

What does this PR do ?

The Options struct passed to the Kuzzle constructor has a connect and a offline_mode fields that can both have 2 values in the JS SDK: manual or auto.
In the Go/Cpp SDK, the connect field type is an enum but not the offline_mode field.

How should this be manually tested?

Step 1 : In the following file internal/wrappers/features/step_defs_cpp/kuzzle-sdk-steps.cpp add this line after the line #101: ctx->kuzzle_options.offline_mode = MANUAL;
Step 2 : Compile

codecov-io commented 6 years ago

Codecov Report

Merging #180 into 1.x will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              1.x     #180   +/-   ##
=======================================
  Coverage   88.97%   88.97%           
=======================================
  Files         244      244           
  Lines        4410     4410           
=======================================
  Hits         3924     3924           
  Misses        454      454           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 407e92e...1e214cd. Read the comment docs.