kuzzleio / sdk-go

Golang SDK using the WebSocket protocol to communicate with Kuzzle API including offline resiliency
http://docs.kuzzle.io/sdk/go/2
Apache License 2.0
8 stars 5 forks source link

add a mapping argument to existing collection.create methods #183

Closed scottinet closed 6 years ago

scottinet commented 6 years ago

What does this PR do ?

Allow Collection.create in Go, C++ and Java to handle a mapping argument, allowing to create new collections directly with a user-mapping specified.

Unit & functional tests have been added.

Other changes

Boyscout

codecov-io commented 6 years ago

Codecov Report

Merging #183 into 1.x will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              1.x     #183      +/-   ##
==========================================
+ Coverage   88.88%   88.92%   +0.03%     
==========================================
  Files         244      244              
  Lines        4410     4416       +6     
==========================================
+ Hits         3920     3927       +7     
+ Misses        458      457       -1     
  Partials       32       32
Impacted Files Coverage Δ
collection/create.go 100% <100%> (ø) :arrow_up:
kuzzle/queue.go 18.18% <0%> (-6.82%) :arrow_down:
realtime/join.go 78.37% <0%> (+5.4%) :arrow_up:
realtime/subscribe.go 77.14% <0%> (+5.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bcb3fc...95341b9. Read the comment docs.