search

kuzzleio / sdk-go

Golang SDK using the WebSocket protocol to communicate with Kuzzle API including offline resiliency
http://docs.kuzzle.io/sdk/go/2
Apache License 2.0
8 stars 5 forks source link

KZL 516 - Change return for validateSpecifications #205

Closed Aschen closed 6 years ago

Aschen commented 6 years ago

What does this PR do?

Before the method ValidationSpecifications returned only a boolean that indicate the specification validity but in the API we are returning additional informations explaining why the specification is invalid.

This PR change the return value of ValidationSpecifications method in the Collection controller.
Now the method return a ValidationResponse which is a structure containing three fields (like in the API):

:warning: I changed the internal/wrappers but they will be removed. See related PR in https://github.com/kuzzleio/sdk-c/pull/6, https://github.com/kuzzleio/sdk-cpp/pull/5 and https://github.com/kuzzleio/sdk-java/pull/8 instead

How should this be manually tested?

Other changes

codecov-io commented 6 years ago

Codecov Report

Merging #205 into 1-dev will decrease coverage by 0.05%. The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff            @@
##           1-dev     #205      +/-   ##
=========================================
- Coverage     89%   88.95%   -0.06%     
=========================================
  Files        243      243              
  Lines       4364     4362       -2     
=========================================
- Hits        3884     3880       -4     
- Misses       453      454       +1     
- Partials      27       28       +1
Impacted Files Coverage Δ
ms/pexpire.go 100% <ø> (ø) :arrow_up:
server/now.go 100% <100%> (ø) :arrow_up:
ms/pexpireat.go 100% <100%> (ø) :arrow_up:
document/search.go 90.9% <33.33%> (-9.1%) :arrow_down:
collection/validate_specifications.go 87.5% <83.33%> (-2.5%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1138e4c...8810da3. Read the comment docs.