search

kuzzleio / sdk-go

Golang SDK using the WebSocket protocol to communicate with Kuzzle API including offline resiliency
http://docs.kuzzle.io/sdk/go/2
Apache License 2.0
8 stars 5 forks source link

Fix cancelSubs #231

Closed jenow closed 5 years ago

jenow commented 5 years ago

What does this PR do?

Fix cancelSubs which was checking if notificationChannel was null before closing onReconnectChannel ... Bad copy paste I guess :p

codecov-io commented 5 years ago

Codecov Report

Merging #231 into 1-dev will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##            1-dev     #231   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         244      244           
  Lines        4488     4488           
=======================================
  Hits         3952     3952           
  Misses        484      484           
  Partials       52       52
Impacted Files Coverage Δ
protocol/websocket/web_socket.go 9.35% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c3204c2...8690814. Read the comment docs.