search

kuzzleio / sdk-javascript

Kuzzle Javascript SDK. High level library including multi-protocol support, offline resiliency, realtime data and more
http://docs.kuzzle.io/sdk/js/7
Apache License 2.0
39 stars 15 forks source link

Allow to use `refresh: false` with `document:upsert|deleteByQuery` #717

Closed alexandrebouthinon closed 1 year ago

alexandrebouthinon commented 1 year ago

Why?

As mentioned in #700 , the refresh option type was not well defined in this section. This as been fixed by @Aschen in the past month but when checking the code before closing the issue, I noticed there were still two action of the document controller that still have a wrongly defined type for this field. In order to close #700, this PR aim to update these

codecov[bot] commented 1 year ago

Codecov Report

Merging #717 (7153843) into 7-dev (f1359dd) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##            7-dev     #717   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files          45       45           
  Lines        2085     2085           
  Branches      397      397           
=======================================
  Hits         1735     1735           
  Misses        272      272           
  Partials       78       78
Impacted Files Coverage Δ
src/controllers/Document.ts 64.63% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.