search

kuzzleio / sdk-jvm

Official Kotlin SDK for Kuzzle
https://kuzzle.io
1 stars 0 forks source link

Fix build gradle #81

Closed CustomEntity closed 2 years ago

CustomEntity commented 2 years ago

What does this PR do ?

How should this be manually tested?

Other changes

Boyscout

CustomEntity commented 2 years ago

Good job +1 some comment about the naming of the SDK You changed the SDK name without from sdk-jvm-x.x.x-without-dependencies.jar to sdk-jvm-.x.x.x.jar And sdk-jvm-.x.x.x.jar to sdk-jvm-x.x.x-with-dependencies.jar

Here you can see that sdk-jvm-.x.x.x.jar was with dependencies and you changed it to be without dependencies, once released on maven people that were importing sdk-jvm-.x.x.x in their pom.xml or build.gradle will have issues because they will have missing dependencies. We should keep the same naming as before to avoid confusing the users when they will be upgrading their version of the SDK.

Also can you please update the compatibility matrix in the README.md

FIxed in commit c1fb776002f48a137ae30d7752d32bce00d1cd45