kvakulo / Switcheroo

The humble incremental-search task switcher for Windows
www.switcheroo.io
GNU General Public License v3.0
789 stars 122 forks source link

Disabling custom hotkey when Alt+Tab is checked #77

Closed tarikguney closed 6 years ago

tarikguney commented 6 years ago

With this PR, users will only be able to use either their custom hotkey or AltTab. This behaviour is also enforced on the UI:

When they check Alt+Tab, the custom hotkey textbox will automatically be disabled.

image

tarikguney commented 6 years ago

Is this project maintained anymore?

kvakulo commented 6 years ago

@tarikguney thanks for the PR. I haven't had much time for this project lately, but I would gladly accept your PR. However, I think it might be worth adding a checkbox next to "Activate Switcheroo with this shortcut", so it possible to have both activated at the same time. What do you think?

tarikguney commented 6 years ago

@kvakulo I am thinking about it but cannot find a use case that could justify having two hotkey doing the same thing. Is that how you are using it? Do you know people requesting that? Thanks for replying.

kvakulo commented 6 years ago

@tarikguney

My reasoning is this:

  1. With the checkbox there's less magic as the user can see right away that the options can be enabled/disabled
  2. My own use of Switcheroo started with using the hotkey, and only later the Alt-Tab hook was added, so sometimes I use one and sometimes the other
  3. When running privileged applications the Alt-Tab hook isn't working #33

But you are surely right. Most people will use only one or the other.

tarikguney commented 6 years ago

For the number 3, you can run the Switcheroo as the administrator and it solves it.

Nevertheless, if you strongly believe that it would be helpful. Then, I will consider adding that.

kvakulo commented 6 years ago

Alright, let's try with your approach, and if somebody besides me need both options it can easily be re-added 😄

Thanks for your PR 👍 🥇

tarikguney commented 6 years ago

Sounds good. Thanks! 💯

tarikguney commented 6 years ago

Also, I will send a new PR soon that will allow people to set a new option as "Run as Administrator at Startup" so that whoever likes it, they can force the application to start as the administrator all the time.

kvakulo commented 6 years ago

Perfect! I'm looking forward for that 👍