search

kvaps / kube-linstor

Containerized LINSTOR SDS for Kubernetes, ready for production use.
Apache License 2.0
130 stars 25 forks source link

Automatically join nodes #26

Closed jbanety closed 3 years ago

jbanety commented 3 years ago

Satellite nodes can with this PR join automatically the cluster.

fixes #23.

kvaps commented 3 years ago

Thanks for amazing work, I'll review it with the other your PRs soon!

jbanety commented 3 years ago

Thanks for amazing work, I'll review it with the other your PRs soon!

Next step is to create storage pool automatically to have counter part of the LinstorSatelliteSet CRD. Some work to do 🧑‍🏭

jbanety commented 3 years ago

@kvaps I added the part for managing creation of storage pools at init. What a good week 😄

jbanety commented 3 years ago

After some testing with a cluster from scratch, it seems that the init container is run too early and so it can't talk to the controller API as it is not up.

kvaps commented 3 years ago

Yeah I wrote about this already :)

Doesn't the storage-pool creation require node to be online? While you run init-container the satellite daemon is not up yet.

I think we can consider to move this logic to linstor-csi daemonset

kvaps commented 3 years ago

Could you rebase storage-pool changes into new PR? I'm going to merge this one

jbanety commented 3 years ago

Could you rebase storage-pool changes into new PR? I'm going to merge this one

Done

kvaps commented 3 years ago

Merged, thanks!