Update zabbix_container.conf

gomusan commented 3 years ago

system.uptime from zabbix-agent is wrong too : it reports uptime from the host, not from the container itself. uptime command and /proc/uptime are right inside the container, so adding a user parameter to rely on them instead. Will need to update Template Linux Container.

kvaps commented 3 years ago

@gomusan, thanks for your PR. Merged!

Unfortunately I don't maintain this project anymore, however if you're interesting in supporting it I can add deprecation warning into README.md file with the link to your fork.

Let me know, if you're interesting in that

kvaps commented 3 years ago

Well, it's never too late to start learning. I still able to manage this repository, so let's use standard pull-request model. You don't need any specific permissions for that.

link my issue " available memory is higher than total memory #7 " to the pull request " Update zabbix_container.conf #9 ", I tried to follow instructions there https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

just edit your PR description and add there this line:

fixes #7

sync my repo with yours : it still show branches "patch-1" "patch-2" "patch-3" and "master" default branch still shows the original files :-/

Clone your repository, then add additional remote:

git remote add upstream https://github.com/kvaps/zabbix-linux-container-template

pull the changes from upstream repo into your local master branch:

git pull upstream master

push changes into your remote repository:

git push orign

Remember never work with the master branch. If you want to prepare new PR, always create new branch, it does not matter which name it will have.

Good luck, and kindly welcome to git! Here you can find other useful instructions https://githowto.com/

gomusan commented 3 years ago

Hello,

Would you mind merging the pull request #9 ? Next step could be adding deprecation warning into README.md file with the link to your fork. And with your support I think I could take over.

Step forward will be to update xml template with uptime.

Thanks, Guillaume

BTW which is the right email address to use to communicate with you ? I feel like I made a mistakbe by answering to all since it github attached the whole thread to "Update zabbix_container.conf #8" and thus linked it to "available memory is higher than total memory #7", which is wrong unfortunately. Better wipe the email thread off of "Update zabbix_container.conf #8" don't you think ? I deleted my emails but I can't remove yours.

De: "Guillaume Laurès" guillaume@lauresfamily.fr À: "kvaps" reply@reply.github.com Cc: "kvaps" zabbix-linux-container-template@noreply.github.com, "Mention" mention@noreply.github.com Envoyé: Mercredi 27 Janvier 2021 19:39:09 Objet: Re: [kvaps/zabbix-linux-container-template] Update zabbix_container.conf (#8)

Hello,

For the link -> got it.

For the sync -> got it too, I tried the following before I got your message and it worked : git remote add upstream https: // github.com / kvaps / zabbix-linux-container-template.git git fetch upstream git rebase upstream / master git rebase upstream / master

I though it would be doable from the github web site itself.

Thanks

De: "Andrei Kvapil" notifications@github.com À: "kvaps/zabbix-linux-container-template" zabbix-linux-container-template@noreply.github.com Cc: "Guillaume Laurès" guillaume@lauresfamily.fr, "Mention" mention@noreply.github.com Envoyé: Mardi 26 Janvier 2021 23:24:37 Objet: Re: [kvaps/zabbix-linux-container-template] Update zabbix_container.conf (#8)

Well, it's never too late to start learning. I still able to manage this repository, so let's use standard pull-request model. You don't need any specific permissions for that.

link my issue " available memory is higher than total memory [ https://github.com/kvaps/zabbix-linux-container-template/issues/7 #7 ] " to the pull request " Update zabbix_container.conf [ https://github.com/kvaps/zabbix-linux-container-template/pull/9 #9 ] ", I tried to follow instructions there [ https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue

https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue ]

just edit your PR description and add there this line: fixes #7

sync my repo with yours : it still show branches "patch-1" "patch-2" "patch-3" and "master" default branch still shows the original files :-/ Clone your repository, then add additional remote: git remote add upstream https://github.com/kvaps/zabbix-linux-container-template

pull the changes from upstream repo into your local master branch: git pull upstream master

push changes into your remote repository: git push orign

Remember never work with the master branch. If you want to prepare new PR, always create new branch, it does not matter which name it will have.

Good luck, and kindly welcome to git! Here you can find other useful instructions [ https://githowto.com/ | https://githowto.com/ ]

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/kvaps/zabbix-linux-container-template/pull/8#issuecomment-767855227 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AC5OGPBVWFL3M6X5ELGMBHTS346KLANCNFSM4WQOM2YA | unsubscribe ] .