kvark / choir

Task Orchestration Framework
MIT License
52 stars 3 forks source link

Sequential test occasionally fails #16

Closed kvark closed 2 years ago

kvark commented 2 years ago
     Running tests/basic.rs (target/debug/deps/basic-c693d3602fd57ec1)

running 6 tests
test child_tasks ... ok
test multi_sum ... ok
test iter_xor ... ok
test parallel ... ok
test zero_count ... ok
test sequential ... FAILED

failures:

---- sequential stdout ----
thread 'sequential' panicked at 'assertion failed: `(left == right)`
  left: `38`,
 right: `100`', tests/basic.rs:52:5
kvark commented 2 years ago

Figured out this isn't a problem with execution dependencies (phew!) but rather with wait_idle. I think we need to rewrite this part of the API from the first principles. For one, we should wait for a particular task instead of all of the tasks.