kvark / claymore

Just another tactical RPG in dark fantasy setting
Apache License 2.0
54 stars 3 forks source link

Added 150 for osx #19

Closed ghost closed 9 years ago

ghost commented 9 years ago

You need the device to do a feature test. But this quick hack will make claymore work on os x.

kvark commented 9 years ago

Are you able to test it? Problem is, grid shader is not the only thing in action. As I said in the release notes, gfx_pipeline has shaders, and they are embedded (using include_bytes!), so I can't just hack them up locally. I know it's not the most portable decision, and I'll definitely reconsider it. But the fact is, pipeline's shaders will fail on OSX, I believe.

cc @bvssvni - could you please run with this PR?

bvssvni commented 9 years ago
$ RUST_BACKTRACE=1 cargo run
     Running `target/debug/claymore`
Initializing the window...
Loading the game...
4 fffffffffffffffb
thread '<main>' panicked at 'called `Result::unwrap()` on an `Err` value: Open(Error { repr: Os(2) })', /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/libcore/result.rs:729
stack backtrace:
   1:        0x10528cebf - sys::backtrace::write::h7c4b7b31b5a98994KVr
   2:        0x105290404 - panicking::on_panic::h130becb52f065864NVv
   3:        0x105285e25 - rt::unwind::begin_unwind_inner::hf2ec506d50a3ea22wDv
   4:        0x10528665c - rt::unwind::begin_unwind_fmt::he465542fba1a288eCCv
   5:        0x10528fcdc - rust_begin_unwind
   6:        0x1052b07a5 - panicking::panic_fmt::h39c9227a84864bb7yKy
   7:        0x10505dda7 - result::Result<T, E>::unwrap::h3626573718932768394
   8:        0x10500f5d3 - App<R>::new::h9092948207858047879
   9:        0x104ffef91 - main::h0668d5b77e85cd49jaa
  10:        0x105291e78 - rust_try_inner
  11:        0x105291e65 - rust_try
  12:        0x105290c08 - rt::lang_start::hb7999e6864f60ac5iQv
  13:        0x105132abe - main
An unknown error occurred
kvark commented 9 years ago

@bvssvni I believe you just don't have the data? I know there needs to be a better error for that.

bvssvni commented 9 years ago

@kvark How do I get the data?

ghost commented 9 years ago

@kvark yes it works on my Macbook air.

image

@bvssvni https://github.com/kvark/claymore/releases/tag/v0.1 data.tgz and place the folder as data into the root directory.

ghost commented 9 years ago

@kvark huh, I took at look at gfx_pipline and it turns out to be using #version 150

kvark commented 9 years ago

@csherratt this is awesome, thank you!

kvark commented 9 years ago

I should just switch the grid shader to be 150 core, since the pipeline requires it anyway.

bvssvni commented 9 years ago

Still getting same error.

kvark commented 9 years ago

@bvssvni you got the sources, and have the data folder in the same folder? How are you starting the game?

bvssvni commented 9 years ago

Figured it out. It works now!

kvark commented 9 years ago

Yay!

Regards, Dzmitry

On Apr 26, 2015, at 16:23, Sven Nilsen notifications@github.com wrote:

Figured it out. It works now!

— Reply to this email directly or view it on GitHub.