kvark / copyless

[deprecated] Avoid memcpy calls when working with standard containers

Apache License 2.0

276 stars 12 forks source link

Replaced *mut T by Option<NonNull<T>> in box.rs #1

Closed danielhenrymantilla closed 5 years ago

kvark commented 5 years ago

@danielhenrymantilla thank you for the PR! It looks good to me. Wondering why you didn't go further as suggested in https://github.com/kvark/copyless/issues/2#issuecomment-475336455 ?

danielhenrymantilla commented 5 years ago

Since you were nowhere to be seen I was on standby ^^'

There it is

novacrazy commented 5 years ago

What’s the status on this?

kvark commented 5 years ago

bors r+

bors[bot] commented 5 years ago

Build succeeded

continuous-integration/travis-ci/push

kvark commented 5 years ago

@danielhenrymantilla we just realized that this PR fixed an UB behavior on alloc() returning NULL. So good thing this is now merged and published. We need to update the use of copyless by library clients to 0.1.4