VecAllocation should have an impl Drop

kvark / copyless

[deprecated] Avoid memcpy calls when working with standard containers

Apache License 2.0

276 stars 12 forks source link

VecAllocation should have an impl Drop #10

Closed glandium closed 5 years ago

glandium commented 5 years ago

Like BoxAllocation, VecAllocaton should have an impl Drop that removes the element that was added if no initialization happened.

kvark commented 5 years ago

No, VecAllocation doesn't need a drop. There is no element added that should be removed: all that's been done by that point is reservation change to the vector, which is fine to leave.