search

kvark / mint

Math Interoperability Types
MIT License
256 stars 20 forks source link

Add 2x4 and 4x2 matrices #43

Closed Osspial closed 5 years ago

Osspial commented 5 years ago

I have no idea if there's any practical use for these, but OpenGL, nalgebra, and probably other math crates expose them and they fit within the 2x2-4x4 matrix range exposed by this crate, so I can't see a reason not to have them.

kvark commented 5 years ago

would be good to have a few tests added for this though... bors r-

Osspial commented 5 years ago

Oh, I didn't notice mint had a test suite! I've added tests in.

Also, it looks like there were a few already-existing matrices not covered in the row_matrix and column_matrix tests, so I've added those in as well.

kvark commented 5 years ago

Thanks a ton! Bors r+

On Sep 16, 2019, at 12:24, Osspial notifications@github.com wrote:

Oh, I didn't notice mint had a test suite! I've added tests in.

Also, it looks like there were a few already-existing matrices not covered in the row_matrix and column_matrix tests, so I've added those in as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Osspial commented 5 years ago

Would it be possible to do a 5.2 release after this is merged?

kvark commented 5 years ago

https://crates.io/crates/mint/0.5.2