kvark / obj

Basic Wavefront OBJ loader
Apache License 2.0
29 stars 12 forks source link

Panic Safety and Mild Cleanup #12

Closed cwfitzgerald closed 4 years ago

cwfitzgerald commented 4 years ago

Resolves #11.

This PR removes all instances of panics where the user didn't ask for a panic. I've tested the tests and against my codebase using it, and everything seems still in order.

Notable changes

Breaking Changes:

Now that I've dug a bit into the codebase, there are a couple of improvements I still want to make. Feel free to comment on any of them 😄. Vaguely in order of importance:

cwfitzgerald commented 4 years ago

All changes should be addressed :)

kvark commented 4 years ago

Are the commits buildable independently? Otherwise we'll squash it (no bors here)

cwfitzgerald commented 4 years ago

I think they all build. I don't recall running tests on all of them but I only committed once I got things working.