search

kvark / obj

Basic Wavefront OBJ loader
Apache License 2.0
29 stars 12 forks source link

Use an external parser #2

Open kvark opened 7 years ago

kvark commented 7 years ago

Current parsing is rather crude, and we could do better with using pom, nom, combine, and such.

cc @csherratt @vitvakatu

vitvakatu commented 7 years ago

I'd like to do it. First time wanted to use nom, but it's not important for me, so I decided to use pom after short conversation with @kvark. @csherratt are there any objections or ideas?

csherratt commented 7 years ago

Just as long as it is quick enough . The benchmarks at the bottom of the pom page (https://github.com/J-F-Liu/pom) do not install confidence. The test asset sponza.obj is 21MB, so performance is pretty important.

vitvakatu commented 7 years ago

Well, I need to check both.

kvark commented 7 years ago

I'm not as concerned about performance here. It would certainly be nice to have, but using Obj for anything non-trivial is a mistake already :)

On Jun 5, 2017, at 11:27, Ilya Bogdanov notifications@github.com wrote:

Well, I need to check both.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.