search

kvark / vange-rs

Rusty Vangers clone
https://vange.rs
Apache License 2.0
432 stars 21 forks source link

Removed palette from MapDescription #194

Closed lpenguin closed 2 years ago

lpenguin commented 2 years ago

We don't use this field in rv_map_init and update the palette in rv_map_update_palette anyway, so it can be safely removed.

kvark commented 2 years ago

We should increase the library version here, i.e "rv_api_1" -> "rv_api_2" (and a line in the mini-changelog comment)

lpenguin commented 2 years ago

Ok, let's wait for models to be merged and then come back to palette fix

lpenguin commented 2 years ago

Should the models update and changed MapDescription have the same rv_api version?

kvark commented 2 years ago

Yes, let's make the model update incorporate this fix as well.

kvark commented 2 years ago

Ok, included this in #191 now