search

kvas-it / pytest-console-scripts

Pytest plugin for testing console scripts
MIT License
78 stars 14 forks source link

Parametrize script runner with `indirect=True` #30

Closed jonchang closed 4 years ago

jonchang commented 4 years ago

This change is needed for pytest 5.4.0

c.f. https://github.com/pytest-dev/pytest/issues/5712

kvas-it commented 4 years ago

Hey! Thanks for the PR.

It seems that the test suite is broken because of changes to virtualenv so I will first need to fix that and then we can land this.

kvas-it commented 4 years ago

It seems that they have reverted the changes in the API (changelog, ticket) so this change is no longer necessary.

Anyway, thanks for the PR -- it motivated me to fix the tests so they now work with the latest version of virtualenv (#31).

I'm leaning towards merging this PR anyway since it doesn't have any downsides and makes it work with pytest 5.4.0. What do you think?

jonchang commented 4 years ago

Might as well; I don't think the indirect parameter is getting removed so it should help with 5.4.0 regardless.

kvas-it commented 4 years ago

Yeah, makes sense. Thank you for the PR!