kvasir-io / Kvasir

C++ Metaprogramming library enabling better static checking and register abstraction in embedded software
Apache License 2.0
409 stars 40 forks source link

use cmake target-interface for easier use of lib #113

Closed ObiWahn closed 4 years ago

ObiWahn commented 7 years ago

https://www.youtube.com/watch?v=bsXLMQ6WgIk - talk on modern cmake

odinthenerd commented 7 years ago

Looks good but I'm not the cmake expert, @chieltbest what do you think?

chieltbest commented 7 years ago

This seems good, we've been using this sort of style for some time now in mpl, so I don't see any problem with it.

LegalizeAdulthood commented 7 years ago

Why leave the old stuff present in the file but commented out?

LegalizeAdulthood commented 7 years ago

Having removed all the source files from the library target, it means that generating a project for an IDE won't show any files in the project. I think this is a mistake.