search

kvdroid / Kvdroid

Some Pyjnius tools for Kivy-Android developments.
MIT License
101 stars 24 forks source link

Create a separate python File for each function and class #2

Closed kengoon closed 3 years ago

kengoon commented 3 years ago

Creating a separate python file for each function and class will make the kivy app not to freeze due to too many pyjnius thread on_ui_thread processes and also it helps to avoid putting unnecessary permission not required by an app.

My kivy app crashes due to the network_state function. I understand pyjnius and that is how I figured out, that I need to request for ACCESS_NETWORK_STATE but for kivy noobs who don't understand will get frustrated. Please do consider this, or can I create a pull request because I'm already working on it

yunus-ceyhan commented 3 years ago

Sure, please create a pull requests. Thanks for your assistance.

kengoon commented 3 years ago

alright working on it

yunus-ceyhan commented 3 years ago

alright working on it

I merged it but made some tiny changes on path file. could you please check.

kengoon commented 3 years ago

Ok

kengoon commented 3 years ago

Sure, I love how you placed both in one file because they both point to same context which is directories , you can close the issue now.