Network status not returning True if mobile data is active.

[yunus-ceyhan]

I just checked it out and confirmed. I'll fix it asap. Thanks for feedback.

[Azag3077]

I already fixed it bro. I have created a Pull Request and merged it but I can't see the changes I made on the main code.

I'm new to GitHub and this is first time creating a PR.

On Sun, Jan 16, 2022, 1:20 PM Yunus Ceyhan @.***> wrote:

I just checked it out and confirmed. I'll fix it asap. Thanks for feedback.

— Reply to this email directly, view it on GitHub https://github.com/kvdroid/Kvdroid/issues/26#issuecomment-1013865765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRWA66E5GGP2QM42YCKHITUWKZYZANCNFSM5MCWP6RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[Azag3077]

Am I supposed to merge the changes I made myself?

On Sun, Jan 16, 2022, 1:23 PM Agboola Odunayo @.***> wrote:

I already fixed it bro. I have created a Pull Request and merged it but I can't see the changes I made on the main code.

I'm new to GitHub and this is first time creating a PR.

On Sun, Jan 16, 2022, 1:20 PM Yunus Ceyhan @.***> wrote:

I just checked it out and confirmed. I'll fix it asap. Thanks for feedback.

— Reply to this email directly, view it on GitHub https://github.com/kvdroid/Kvdroid/issues/26#issuecomment-1013865765, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRWA66E5GGP2QM42YCKHITUWKZYZANCNFSM5MCWP6RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[yunus-ceyhan]

Ok i checked your solution and fixed it by it. Thanks for your contribution.

https://github.com/kvdroid/Kvdroid/commit/cc9241f7f43fb3bc3d72ee8201dc1bb3627fe1fb

[Azag3077]

Alright, thanks. I wanted to ask...Did I do the Pull Request the right way? I was hoping to see my changes or link on the pull request tab but I didn't and I was thinking no one too will.

On Sun, Jan 16, 2022, 2:11 PM Yunus Ceyhan @.***> wrote:

Ok i checked your solution and fixed it by it. Thanks for your contribution.

cc9241f https://github.com/kvdroid/Kvdroid/commit/cc9241f7f43fb3bc3d72ee8201dc1bb3627fe1fb

— Reply to this email directly, view it on GitHub https://github.com/kvdroid/Kvdroid/issues/26#issuecomment-1013873547, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRWA66IX4CJ3H2DFQ74MOLUWK7W3ANCNFSM5MCWP6RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

[yunus-ceyhan]

After commiting changes on your fork just create a pull request then wait for the repo owner to merge it.

[Azag3077]

Thank you

On Sun, Jan 16, 2022, 2:58 PM Yunus Ceyhan @.***> wrote:

After commiting changes on your fork just create a pull request then wait for the repo owner to merge it.

— Reply to this email directly, view it on GitHub https://github.com/kvdroid/Kvdroid/issues/26#issuecomment-1013881208, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQRWA656ZWUVCGYO7YPFCHLUWLFIBANCNFSM5MCWP6RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>