search

kveeiv / extjs-boxselect

Ext.ux.form.field.BoxSelect
http://kveeiv.github.com/extjs-boxselect/examples/boxselect.html
MIT License
108 stars 53 forks source link

Not compatible with new Sencha Cmd #22

Open Reggino opened 11 years ago

Reggino commented 11 years ago

Thanks for your great work!

When building a project that contains extjs-boxselect using the new Sencha Cmd [http://www.sencha.com/blog/all-new-sencha-cmd/] , the build fails:

[INFO ] Processing class inheritance graph [INFO ] Processing instantiation refereces to classes and aliases [INFO ] Processing source dependencies [ERROR] Circular requires reference : .\development\app\app.js -> .\development\app\controller\ObjectSelect.js -> .\development\app\form\field\MultipleObjectComboBox.js -> .\development\ext-addons\form\field\BoxSelect.js -> .\development\ext-addons\form\field\BoxSelect.js

This is caused by the declaration of both 'Ext.ux.form.field.BoxSelect' and 'Ext.ux.layout.component.field.BoxSelectField' in the same file: sencha cmd can not handle that. Splitting the file in parts should fix this issue.

jasontwill commented 11 years ago

Confirmed. Separating the 2 declarations into files works. Make sure you put the BoxSelectField before BoxSelect.

amackay11 commented 11 years ago

Since we are using 'Ext.ux.layout.component.field.BoxSelectField' and 'Ext.ux.form.field.BoxSelect' I'm unsure how to split the files. Perhaps this is more of a Sencha CMD question but an example would be nice. Would I copy the files into the Ext.ux directory structure or my own structure boxselect/src/...? Thanks.

gabeattack commented 11 years ago

I've submitted a pull request https://github.com/kveeiv/extjs-boxselect/pull/24. I tried to remember the changes I made previously to get this to work so please let me know if you have any issues and I'll try to install CMD3 on my current computer.

Reggino commented 11 years ago

This issue is fixed in pull request #27 too