search

kvernnn / pe

0 stars 0 forks source link

Unspecified Usage of Filter Function #10

Open kvernnn opened 3 days ago

kvernnn commented 3 days ago

image.png

Steps:

  1. Run command filter Applied Screening Interviewed Offer Onboarding Hired Rejected
  2. Expected: Error message as specified in UG that filter takes in a status under filter command section
  3. Actual: Successfully filtered multiple statuses

Though this is a hidden benefit for the filter function, it is unspecified in the UG. Would be good to inform users that multiple statuses can be filtered at once.

nus-pe-script commented 5 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for raising this issue. After reviewing the reported behavior, we would like to clarify the following:

The team has assessed this issue as a 'suggestion' and an 'improvement'. The images below are retrieved from the CS2103 PE.

image.png

image.png

As referenced from the website, the dev team is allowed to reject bug reports framed as mere suggestions.

Under the User Guide, it is mentioned that an error message will appear when the user inputs an invalid status. The command filter Applied Screening Interviewed Offer Onboarding Hired Rejected is not an error as its arguments are valid statuses and it will not have any error messages. Valid statuses: Applied, Screening, Interview Scheduled, Interviewed, Offer, Onboarding, Hired, Rejected.

As you mentioned, filtering many types is considered to be a 'hidden benefit' and not a bug. This issue is considered to be a 'missing feature'.

Hence, the dev team has assessed this issue as a suggestion and will be putting this as 'response.NotInScope'.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]