search

kvernnn / pe

0 stars 0 forks source link

Edit Allows Duplicate Name #3

Open kvernnn opened 3 days ago

kvernnn commented 3 days ago

image.png

Caution in add command image.png

Caution in edit command image.png

Steps:

  1. Run the command edit 1 n/Bernice Yu where Bernice Yu is the name of the contact at the second index.
  2. Expected to fail since in the add command, it is specified that no two contacts can have the same name or number. In edit command, it is also specified that a candidate cannot be edited to have the same name or number.
  3. Command successfully gone through as seen in the screenshot, no error is thrown.

This contradicts with the initial declared functionality in the UG.

nus-se-bot commented 10 hours ago

Team's Response

Thank you for raising this issue. After reviewing the reported behavior, we would like to clarify the following:

Under the user guide, it was mentioned that the duplicates are checked through the same name and same phone number. The guide does not mention that two candidates cannot have the same name or same phone number. They cannot have the same name and number together. You may refer to the image below.

image.png

It is entirely possible for candidates to have the same name or same phone number (Eg. Different people can live in the same house and use the same house number). It is exceedingly rare for different people to have the same name and phone number, hence the dev team has made it so that duplicates are checked through the same name and same phone number.

Since this functionality does not contradict the User Guide, we are rejecting this issue.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]