search

kvesteri / postgresql-audit

Audit trigger for PostgreSQL
BSD 2-Clause "Simplified" License
126 stars 28 forks source link

fix: use a finally block for 'disable' #42

Closed ElPicador closed 4 years ago

ElPicador commented 4 years ago

If the yield in the disable function was raising an exception the audit was staying disabled for the rest of the sessions (which can cause issues in long running jobs)

kvesteri commented 4 years ago

Please fix the lint errors (see CI), otherwise this looks good

ElPicador commented 4 years ago

@kvesteri done!

kvesteri commented 4 years ago

Thanks for the PR! 🚋

ElPicador commented 4 years ago

Thanks for the PR! 🚋

You're welcome 🙇

Do you know when you plan to do a release with this fix included?

kvesteri commented 4 years ago

Do you know when you plan to do a release with this fix included?

Now. 😉

ElPicador commented 4 years ago

Thanks a lot @kvesteri!