SADeprecationWarning: The Session.close_all()

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.

BSD 3-Clause "New" or "Revised" License

575 stars 127 forks source link

SADeprecationWarning: The Session.close_all() #262

Open TomGoBravo opened 2 years ago

TomGoBravo commented 2 years ago

Running py.test tests/test_validity_strategy.py from the current master outputs:

tests/test_validity_strategy.py::TestJoinTableInheritanceWithValidityVersioning::test_all_tables_contain_transaction_id_column
  sqlalchemy-continuum/tests/__init__.py:133: SADeprecationWarning: The Session.close_all() method is deprecated and will be removed in a future release.  Please refer to session.close_all_sessions().
    self.session.close_all()

This happens with sqlalchemy 1.4.31 and 1.3.24

indiVar0508 commented 2 years ago

Hi @TomGoBravo ,

yeah it seems that warning would appear for all versions of sqlalchemy >1.3 link

have raised a PR for same, you can check once.

Thanks

AbdealiLoKo commented 2 years ago

Now that https://github.com/kvesteri/sqlalchemy-continuum/pull/279 is merged. This ticket can probably be closed as fixed @marksteward