fix issue 85 "TransactionBase.changed_entities fails without TransactionChanges plugin"

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.

BSD 3-Clause "New" or "Revised" License

575 stars 127 forks source link

fix issue 85 "TransactionBase.changed_entities fails without TransactionChanges plugin" #268

Closed TomGoBravo closed 2 years ago

TomGoBravo commented 2 years ago

add test that reproduces issue 85 "TransactionBase.changed_entities fails without TransactionChanges plugin" and fix that has Transaction.entity_names raise a NoChangesColumn instead of AttributeError.

marksteward commented 2 years ago

Thanks for this! It looks like test_transaction_changed_entities is now failing.

I've never used the plugin, but it looks like changes is a relationship, not a column. Is hasattr more appropriate?

marksteward commented 2 years ago

Sorry to be fussy, but could you rename NoChangesColumn to NoChangesAttribute? Otherwise looks great!

TomGoBravo commented 2 years ago

Sorry to be fussy, but could you rename NoChangesColumn to NoChangesAttribute? Otherwise looks great!

Done. Thank you for helping me keep the code to a high standard.