fix for unit_of_work.py:263: SAWarning: implicitly coercing SELECT object to scalar subquery

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.

BSD 3-Clause "New" or "Revised" License

575 stars 127 forks source link

fix for unit_of_work.py:263: SAWarning: implicitly coercing SELECT object to scalar subquery #269

Closed TomGoBravo closed 2 years ago

TomGoBravo commented 2 years ago

Tested by running DB=sqlite py.test tests with pip install SQLAlchemy==1.4.31 With master: 653 passed, 99 skipped, 4909 warnings in 65.90s (0:01:05) With this change: 653 passed, 99 skipped, 4695 warnings in 64.93s (0:01:04) and then again with pip install SQLAlchemy==1.3.24 655 passed, 97 skipped, 657 warnings in 64.88s (0:01:04)

marksteward commented 2 years ago

Thanks for this!

indiVar0508 commented 2 years ago

@marksteward We are facing this issue in our codebase, we see that this has not been published on PyPi, is there any ETA when this will be published

marksteward commented 2 years ago

@indiVar0508 there are a lot of warnings associated with the upgrade to SQLAlchemy 1.4, but they are just warnings, and don't affect functionality. I'm not going to issue a release every time one is fixed.

There are a couple more PRs that fix some of the most frequent warnings, and I was planning to cut a release after they're merged, but I don't know when that will be.