(ISSUE-272) Allow to disable mod plugin in sync_triggers

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.

BSD 3-Clause "New" or "Revised" License

575 stars 127 forks source link

(ISSUE-272) Allow to disable mod plugin in sync_triggers #273

Closed nanvel closed 2 years ago

nanvel commented 2 years ago

The pg audit function was failing because it is built with _mod feature enabled by default.

There are a few ways to disable it, I had to copy/change sync_triggers, and I see other developers fork the repository. Neither of the solutions is good.

This PR allows passing create_triggers arguments as sync_triggers kwargs.

I don't see a good way to detect if the plugin is enabled in sync_triggers.

marksteward commented 2 years ago

Thanks for this! I don't use the trigger-based versioning, so please let me know if there are any other outstanding issues and I'll put aside some time to improve documentation. I'm currently aware of #272 and #114.