search

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.
BSD 3-Clause "New" or "Revised" License
580 stars 126 forks source link

Fix SAWarning for scalar_subquery warning SQLA<1.4 #300

Closed indiVar0508 closed 2 years ago

indiVar0508 commented 2 years ago

Attempt to fix all the scalar_subquery warning identified in this action_job run as part of #263 , used same sol used in #269 by @TomGoBravo

Pytest run on Master: 345 failed, 309 passed, 14 skipped, 302 warnings, 90 errors Pytest run after changes: 345 failed, 309 passed, 14 skipped, 238 warnings, 90 errors

indiVar0508 commented 2 years ago

Hi @marksteward ,

can you review this PR and trigger Travis Build for this one also?

indiVar0508 commented 2 years ago

Hi @marksteward ,

The last Job run failed it seems due to FROM clause subquery i have added a fix for that in this commit, and tested in my local with SQLA >1.4 and <1.4 with mysql server for tests/test_accessors.py and it seems to work.

Could you review and re-trigger the travis CI Build ?

indiVar0508 commented 2 years ago

Hi @marksteward ,

Could also trigger Travis Build for this one

indiVar0508 commented 2 years ago

Hey,

Not sure, but travis build is showing failed for this one some checkout task failed is it ok ?

marksteward commented 2 years ago

Yeah, it cancelled the run because I merged it. The main branch is passing fine.