search

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.
BSD 3-Clause "New" or "Revised" License
575 stars 127 forks source link

Fix for SQLA>1.4 warnings for relationship in test(s) #302

Closed indiVar0508 closed 2 years ago

indiVar0508 commented 2 years ago

Attempt to address SQLA Relationship warning(s) happening in test files test_association_table_relations and test_custom_condition_relations to reduce warnings in action job run for sqla > 1.4 in cont. for #263

pytest run in master : 345 failed, 309 passed, 14 skipped, 302 warnings, 90 errors pytest run after changes : 345 failed, 309 passed, 14 skipped, 278 warnings, 90 errors

indiVar0508 commented 2 years ago

Hi @marksteward ,

can you review this PR and trigger Travis Build for this one also?

AbdealiLoKo commented 2 years ago

Reviewed the PR - looks good to me

indiVar0508 commented 2 years ago

Hi @marksteward ,

can you trigger Travis Build for this one for latest change for this PR, if the changes are ok could you accept it?

marksteward commented 2 years ago

I'm out this evening (UK time) but should be able to look at these tomorrow. Thanks for all your effort!

indiVar0508 commented 2 years ago

Hi ,

I checked the issue for which it failed last time i missed to check for version of SQLA before using overlaps , i have fixed it and tested SQLA < 1.4 with SQLITE , mysql and POSTGRES in my local and it seems to work.

Could you re-trigger the Travis Build again?

Thanks

marksteward commented 2 years ago

Thanks! The version check requirement is a pain but hopefully we don't need to support 1.3 for too long.

indiVar0508 commented 2 years ago

cat-meme