alliefitter
commented
1 year ago Spent some more time on tests, and found a couple more bugs in the package. All tests, aside from i18n and test_savepoints are working with sqlite. Removing the mocking of _SessionSignalEvents's register method seems to have resolved any problems in plugins.test_flask, and there doesn't seem be any side effects from not mocking event listener registration in other tests, as the comment suggests. i18n is failing seemingly because it doesn't appear to be compatible with 2.0. The GitHub hasn't been touched since 2021, and 2.0 was released this year.
There are several test cases which hang when using postgres as the driver. The most recent commit has added some skipif for these tests. The intention there is to skip those tests temporarily in order to find errors specific to postgres, if any. I'm not sure what exactly is causing it, but when it happens, these queries are stuck in pg_stat_activity. The former's state is idle in transaction while the latter's is active. This is probably an obvious problem to someone more experienced with sqlalchemy than I am.
DROP SEQUENCE transaction_id_seq;
CREATE TABLE text_item (
id SERIAL NOT NULL,
PRIMARY KEY (id)
);
marksteward
POD666
progmancod
This is a just a stopgap, but I've attempted to add support for SqlAlchemy 2.0. Most
select()statements were able to be updated to 2.0 syntax without issue, while some would only work withorm.Query().text()was added to any query literals. It seems that basic functionality is g2g, but there's some weirdness with the unit tests. The vast majority of top level tests succeed when running the entire suite, but many of the nested tests (relationships, plugins) failed unless they're run on their own. There are also some tests (test_savepoints.py) that either I'm not understanding the intent of or are just broken. Also, I skipped the flask tests, as I'm unfamiliar with the_SessionSignalEventsthat's being imported in the test file, but it seems to have been removed from Flask-SQLAlchemy. I'm not sure how to adapt the tests to the current state of the flask plugin. I'm not sure what the state of tests were before this fork, and how many were regularly failing, so any context there would be greatly appreciated. I should note that I've only run the tests with sqlite, so the issues I'm running into may be specific that database.