search

kvesteri / sqlalchemy-continuum

Versioning extension for SQLAlchemy.
BSD 3-Clause "New" or "Revised" License
568 stars 128 forks source link

`version.changeset` vs `changeset(obj)` order consistency #354

Open PeterSR opened 1 month ago

PeterSR commented 1 month ago

Hi

version.changeset has values like [old, new]

Code: https://github.com/kvesteri/sqlalchemy-continuum/blob/91730be62d7d3e15a8c69e57d5b5aa1ecd82f1f4/sqlalchemy_continuum/version.py#L46

but changeset(obj) has values like [new, old]

Code: https://github.com/kvesteri/sqlalchemy-continuum/blob/91730be62d7d3e15a8c69e57d5b5aa1ecd82f1f4/sqlalchemy_continuum/utils.py#L402

It seems for instance that #243 fixes documentation instead of the code, re-enforcing that it should be like this. But is it intentional?